Task #8315 (closed)
Opened 12 years ago
Closed 12 years ago
Add trusted usedFiles flag
| Reported by: | cblackburn | Owned by: | cblackburn |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-4.4.7 |
| Component: | Bin-Services | Version: | n.a. |
| Keywords: | n.a. | Cc: | jburel |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | n.a. |
Description
Add a flag to the ImportContainer? to signal that the usedFiles is a complete set that has been resolved by the client. Under these circumstances the server-side import does not need to resolve the set again.
Change History (12)
comment:1 Changed 12 years ago by jburel
- Cc jburel added
comment:2 Changed 12 years ago by jburel
comment:3 Changed 12 years ago by cblackburn
- Remaining Time changed from 0.5 to 0.25
- Sprint changed from 2012-03-27 (11) to 2012-04-10 (12)
comment:4 Changed 12 years ago by cblackburn
Due to the current workflow an import client is required to have the usedFiles for a normal import and so this should still be passed as an argument. A case of a flag might be where the usedFiles contains an unresolved set of files that are then resolved into import candidates server-side. This workflow could be exploited to facilitate web-based imports.
comment:5 Changed 12 years ago by jburel
- Sprint changed from 2012-04-10 (12) to 2012-04-24 (13)
Moved from sprint 2012-04-10 (12)
comment:6 Changed 12 years ago by jburel
- Sprint changed from 2012-04-24 (13) to 2012-05-08 (14)
Moved from sprint 2012-04-24 (13)
comment:7 Changed 12 years ago by cblackburn
- Sprint 2012-05-08 (14) deleted
comment:8 Changed 12 years ago by cblackburn
Referencing ticket #909 has changed sprint.
comment:9 Changed 12 years ago by cblackburn
- Milestone changed from OMERO-Beta4.4 to Future
comment:10 Changed 12 years ago by jmoore
Referencing ticket #909 has changed sprint.
comment:11 Changed 12 years ago by jmoore
- Milestone changed from Future to OMERO-4.5
Colin, is this still valid? I would think that we now must trust the files that have been uploaded during import, and at the same time, that we will be called setId anyway. Please close if no longer valid.
comment:12 Changed 12 years ago by cblackburn
- Remaining Time changed from 0.25 to 0
- Resolution set to invalid
- Status changed from new to closed
Agreed.
Previously it was not necessary to specify the usedFiles. We just had to pass null.
It might be better not to introduce a flag but if usedFiles is null, then use import candidates, so we do not break people's code.
if we decided to go for a flag then it is necessary to handle the null usedFiles case to avoid NPE.