Task #8316 (closed)
Refactor MinMax calculation
| Reported by: | cblackburn | Owned by: | cblackburn |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-4.4 |
| Component: | Bin-Services | Version: | n.a. |
| Keywords: | n.a. | Cc: | jamoore, jburel, cxallan, atarkowska |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2012-04-10 (12) |
Description
All fs-lite files have their MinMax calculation done in the PixelData thread. This was necessary for big images but is not needed for all imports. For non-big images this calculation and subsequent thumbnail generation should be moved back into the main import workflow.
Change History (5)
comment:1 Changed 12 years ago by cblackburn
- Status changed from new to accepted
comment:2 Changed 12 years ago by cblackburn
- Cc jmoore jburel cxallan atarkowska added
- Remaining Time changed from 1 to 0.25
comment:3 Changed 12 years ago by jburel
- Sprint changed from 2012-03-27 (11) to 2012-04-10 (12)
Moved from sprint 2012-03-27 (11)
comment:4 Changed 12 years ago by cblackburn
- Remaining Time changed from 0.25 to 0
- Resolution set to fixed
- Status changed from accepted to closed
Memory leak was unrelated to #6349. It was a failure to close services from the repo.
comment:5 Changed 12 years ago by Chris Allan <callan@…>
(In [3f976a99bc5268ea974cb0b9f1ffaf77d690f2c5/ome.git] on branch develop) Parse the binary data during import to generate min/max values. See #8316
This also allows a SHA1 to be calculated but the resulting value might not
be useful unless compared against a SHA1 using the same method.
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
This has been done in branch but it has moved an OOM that was being "managed" in the PixelData thread into the main import workflow which is fairly catastrophic after a number of imports depending on the number, image size and heap space. This may be a result of #6349 and so that bug should be fixed.