Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #6349 (closed)

Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

Close a RepoRawFileStore (and bfPixelStore)

Reported by: cblackburn Owned by: jamoore
Priority: major Milestone: OMERO-4.4.7
Component: Bin-Services Version: n.a.
Keywords: n.a. Cc: jamoore, cxallan, jburel
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2012-10-23 (1)

Description

Currently calling close() on a RepoRawFileStore (and other proxies created using file names by the Repository service) generates an NPE. These proxies need to handle close and tidy up after themselves.

Change History (27)

comment:1 Changed 13 years ago by cxallan

  • Sprint changed from 2011-08-04 (2) to 2011-08-18 (3)

Moved from sprint 2011-08-04 (2)

comment:2 Changed 13 years ago by jburel

  • Sprint changed from 2011-08-18 (3) to 2011-09-01 (4)

Moved from sprint 2011-08-18 (3)

comment:3 Changed 13 years ago by jburel

  • Sprint changed from 2011-09-01 (4) to 2011-09-15 (5)

Moved from sprint 2011-09-01 (4)

comment:4 Changed 13 years ago by jburel

  • Sprint changed from 2011-09-15 (5) to 2011-09-29 (6)

Moved from sprint 2011-09-15 (5)

comment:5 Changed 13 years ago by jburel

  • Milestone changed from OMERO-Beta4.3.2 to OME-5.0
  • Sprint 2011-09-29 (6) deleted

comment:6 Changed 12 years ago by cblackburn

  • Owner set to cblackburn
  • Priority changed from major to blocker
  • Sprint set to 2012-03-13 (10)
  • Status changed from new to accepted

This bug is now proving to be a blocker for server-side imports triggered through the repository service.

comment:7 Changed 12 years ago by cblackburn

  • Remaining Time set to 0.5

comment:8 Changed 12 years ago by cblackburn

  • Priority changed from blocker to major
  • Sprint changed from 2012-03-13 (10) to 2012-03-27 (11)

No the blocker I thought it was. Moving to next sprint and downgrading.

comment:9 Changed 12 years ago by cblackburn

  • Owner cblackburn deleted
  • Status changed from accepted to new

comment:10 Changed 12 years ago by cblackburn

  • Sprint changed from 2012-03-27 (11) to 2012-04-10 (12)

comment:11 Changed 12 years ago by cblackburn

  • Cc jburel atarkowska added
  • Owner set to cblackburn
  • Priority changed from major to blocker
  • Status changed from new to accepted

See #8316 This issue is now a blocker.

comment:12 Changed 12 years ago by cblackburn

  • Sprint changed from 2012-04-10 (12) to 2012-03-27 (11)

comment:13 Changed 12 years ago by jburel

  • Sprint changed from 2012-03-27 (11) to 2012-04-10 (12)

Moved from sprint 2012-03-27 (11)

comment:14 Changed 12 years ago by cblackburn

  • Priority changed from blocker to major

No longer a blocker. I have a local fix but need to discuss with Josh how best it should be implemented.

comment:15 Changed 12 years ago by cblackburn

  • Cc atarkowska removed

comment:16 Changed 12 years ago by cblackburn

  • Sprint changed from 2012-04-10 (12) to 2012-04-24 (13)

comment:17 Changed 12 years ago by cblackburn

  • Owner cblackburn deleted
  • Status changed from accepted to new

comment:18 Changed 12 years ago by jburel

  • Sprint changed from 2012-04-24 (13) to 2012-05-08 (14)

Moved from sprint 2012-04-24 (13)

comment:19 Changed 12 years ago by jburel

  • Sprint changed from 2012-05-08 (14) to 2012-05-22 (15)

Moved from sprint 2012-05-08 (14)

comment:20 Changed 12 years ago by jburel

  • Sprint changed from 2012-05-22 (15) to 2012-06-05 (16)

Moved from sprint 2012-05-22 (15)

comment:21 Changed 12 years ago by jburel

  • Milestone changed from OMERO-Beta4.4 to OMERO-Beta4.4.1
  • Sprint 2012-06-05 (16) deleted

moving that out of the sprint, not part of 4.4

comment:22 Changed 12 years ago by cblackburn

Referencing ticket #909 has changed sprint.

comment:23 Changed 12 years ago by jmoore

Referencing ticket #909 has changed sprint.

comment:24 Changed 12 years ago by jmoore

  • Owner set to jmoore
  • Remaining Time changed from 0.5 to 0.1
  • Sprint set to 2012-10-23 (1)
  • Status changed from new to accepted

This looks to be an issue with missing configuration (rfs.setApplicationContext) though there may be other issues involved.

comment:25 Changed 12 years ago by jmoore

  • Remaining Time changed from 0.1 to 0
  • Resolution set to fixed
  • Status changed from accepted to closed 
commit f1e7ef8b4b69672a8bf4135cdea5d0dfe9a11e08
Author: jmoore <josh@glencoesoftware.com>
Date:   Mon Oct 1 20:43:52 2012

    Fix NPE on RFS.close (Fix #6349)

Haven't opened a PR since 383 hasn't been merged yet.

comment:26 Changed 12 years ago by jmoore <josh@…>

(In [cfe7005a7767e7115e952b5e6b46f4d88cb92911/ome.git] on branch develop) Fix NPE on RFS.close (Fix #6349)

comment:27 Changed 12 years ago by jmoore <josh@…>

(In [73a2febeff5c03ec747e039d7bb4c123d81c9d24/ome.git] on branch develop) Another NPE fix for RepoRawFileStoreI (See #6349)

The holder must also be set in order to prevent an NPE
during cleanup. I went ahead and took the time to refactor
the two uses into a single method. This metho could possibly
be moved into the ctor of RepoRFS itself.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.73799 sec.)

© 2000-2014 University of Dundee & Open Microscopy Environment. Creative Commons Attribution 3.0 Unported License
OME source code is available under the GNU General public license or through commercial license from Glencoe Software

We're Hiring!