Task #8573 (closed)
multi_group scripts
| Reported by: | wmoore | Owned by: | jamoore |
|---|---|---|---|
| Priority: | blocker | Milestone: | OMERO-4.4 |
| Component: | Scripting | Version: | n.a. |
| Keywords: | n.a. | Cc: | atarkowska, cxallan, jburel, |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2012-04-24 (13) |
Description
Currently, if am logged in to 'group1' and I set my 'omero.group' to 'group2', the scripts I run with runScript() will have an event context of 'group1'. This is a problem if I want sripts to access data in group2.
I will create a test, then pass to Josh to fix.
Change History (8)
comment:1 Changed 12 years ago by wmoore
- Status changed from new to accepted
comment:2 Changed 12 years ago by wmoore
- Owner changed from wmoore to jmoore
comment:3 Changed 12 years ago by jmoore
- Remaining Time set to 0.1
Will, fix has been pushed:
- https://github.com/joshmoore/openmicroscopy/tree/group_switch_8102
- https://github.com/joshmoore/openmicroscopy/commit/aa7d7681579418e32c816e2020d5ca52310827b3
Primarily need to discuss merge strategy, though there may still be some code paths that need to have the call context path (both client- and server-side)
comment:4 Changed 12 years ago by wmoore
- Remaining Time changed from 0.1 to 0
- Resolution set to fixed
- Status changed from accepted to closed
Merged Josh's changes, added a final commit https://github.com/will-moore/openmicroscopy/commit/ddd81a522ca448a8a0317001945233ed91a59ea0
Scripts seem to be running OK now.
Closing...
comment:5 Changed 12 years ago by Will Moore <will@…>
(In [5ff97e6fbd6da47369f1c1123fdcda563ce7dc12/ome.git] on branch develop) Script multi-group test fails. See #8573
comment:6 Changed 12 years ago by jmoore <josh@…>
(In [2a7f0acd6d511205a3adedc1be3746a1882d70fc/ome.git] on branch develop) Pass context on runScript (Fix #8573)
Guaranteeing that the appropriate group was
used for script execution required a few different
tweaks:
- sessionManager.getEventContext(uuid) is not longer
valid and instead a full Executor.execut(callContext
invocation is needed.
- Ice.Current must be passed around far more frequently if not always.
Some of these changes could be made unnecessary by larger
scale changes (such as storing Ice.Current in a ThreadLocal?)
but for the moment, this gets Will's tests passing.
comment:7 Changed 12 years ago by jmoore <josh@…>
(In [aa7d7681579418e32c816e2020d5ca52310827b3/ome.git] on branch develop) Pass omero.group on runScript in test (See #8573)
comment:8 Changed 12 years ago by Will Moore <will@…>
(In [ddd81a522ca448a8a0317001945233ed91a59ea0/ome.git] on branch develop) runScript uses conn.CONFIGSERVICE_OPTS?. Closes #8573
Failing gateway test commit: https://github.com/will-moore/openmicroscopy/commit/5ff97e6fbd6da47369f1c1123fdcda563ce7dc12
On branch https://github.com/will-moore/openmicroscopy/commits/group_switch_8102
Over to you Josh...