Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9014 (closed)

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

Bug: script output display

Reported by: jburel Owned by: sbesson
Priority: major Milestone: OMERO-4.4
Component: Scripting Version: n.a.
Keywords: n.a. Cc: ux@…, sbesson, bpindelski, jamoore, wmoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: 2012-06-05 (16)

Description

Logged in as user-6 read-only-1. Selected image with Z-stack. Ran script to create movie. Activity window reported script successfully completed (screenshot 1). No change to attachments in right pane (screenshot 1). Went into right pane and clicked refresh. Blank drop-down box appeared (screenshot 2). Could get drop-down menu on this box (screenshot 3). Selected "View" - presented with empty folder where movie should be (screenshot 4). Selected “unlink” - appeared to work as expected. Selected “delete” - appeared to work and gave successful delete message in activities window. Selected “Info” - gave credible file information (screenshot Info.png). Subsequent refresh of data tree shows that image with "annotation" tag (screenshot 5).
Note:
When trying to view output from “ROI Split Figure” script - the missing file from the “Movie ROI” script - File_2577 - appeared in the window with the file path:

psf\Home\omero\filesOmero
(screenshot Gus/Testing? 12-05-28/filesOmero.png)
Note: none of the files created as output - according to the "info" showed in the "Attachments" tab of the data pane and a system Finder search of the HD for the file ID failed to locate any.

Change History (11)

comment:1 Changed 12 years ago by bpindelski

  • Cc bpindelski added

comment:2 Changed 12 years ago by jburel

  • Cc jmoore added
  • Component changed from Insight to Services
  • Owner jburel deleted

The problem seems to come from the RawFileStore.save() method, more specifically new ShallowCopy().copy(file). This requires more investigation.
Sebastien could you review FileAnnoationData and OriginalFile linkage?

Last edited 12 years ago by jburel (previous) (diff)

comment:3 Changed 12 years ago by jburel

Sebastien, J-M:
name is not set in original file neither in File annotation when the script generates a figure. The name is set in the path. e.g. XXX.png
Strategy in production is:

  • set the name to XXX.png and path empty string.
  • Add control to pojos to handle the mismatch.

comment:4 Changed 12 years ago by jburel

cf72827 review handling of name in pojos

comment:5 Changed 12 years ago by jburel

  • Cc wmoore added
  • Owner set to sbesson

comment:6 Changed 12 years ago by jburel

  • Component changed from Services to Scripting

comment:7 Changed 12 years ago by jburel

  • Sprint set to 2012-06-05 (16)

comment:8 Changed 12 years ago by sbesson

  • Resolution set to fixed
  • Status changed from new to closed

Bug in file creation: name was set in OriginalFile? path and OriginalFile? name was left empty.

ee44869 Fix path/name inversion during original file creation (see #9014)

Last edited 12 years ago by sbesson (previous) (diff)

comment:9 Changed 12 years ago by jburel <j.burel@…>

(In [98398be147bd921401f1f2575f89fd12fde3928c/ome.git] on branch develop) Review linkage between original and annotation (see #9014)

comment:10 Changed 12 years ago by jburel <j.burel@…>

(In [cf72827c9d0d575c3b289f24bfdc2fe8633eaa79/ome.git] on branch develop) Improve handling of Original File "name" (see #9014)

comment:11 Changed 12 years ago by Sebastien Besson <seb.besson@…>

(In [ee44869db54087f651a11d90c922a81373f4052c/ome.git] on branch develop) Fix path/name inversion during original file creation (see #9014)

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.69655 sec.)

We're Hiring!