BUG: Tags appearing as comments

[ajpatterson]

If an OME file has tag annotations e.g.

      <!-- First Tag -->
      <SA:StringAnnotation ID="Annotation:1" Namespace="openmicroscopy.org/omero/insight/tag">
         <SA:Value>SampleTagA</SA:Value>
      </SA:StringAnnotation>
      <SA:StringAnnotation ID="Annotation:2" Namespace="openmicroscopy.org/omero/annotation/description">
         <SA:Value>This is the description of the sample tag A</SA:Value>
      </SA:StringAnnotation>
      <SA:ListAnnotation ID="Annotation:3" Namespace="openmicroscopy.org/omero/annotation/link">
         <SA:AnnotationRef ID="Annotation:1"/>
         <SA:AnnotationRef ID="Annotation:2"/>
      </SA:ListAnnotation>
      <!-- Second Tag -->
      <SA:StringAnnotation ID="Annotation:4" Namespace="openmicroscopy.org/omero/insight/tag">
         <SA:Value>SampleTagB</SA:Value>
      </SA:StringAnnotation>
      <SA:StringAnnotation ID="Annotation:5" Namespace="openmicroscopy.org/omero/annotation/description">
         <SA:Value>This is the description of the sample tag B</SA:Value>
      </SA:StringAnnotation>
      <SA:ListAnnotation ID="Annotation:6" Namespace="openmicroscopy.org/omero/annotation/link">
         <SA:AnnotationRef ID="Annotation:4"/>
         <SA:AnnotationRef ID="Annotation:5"/>
      </SA:ListAnnotation>
      <!-- A Tagset -->
      <SA:StringAnnotation ID="Annotation:7" Namespace="openmicroscopy.org/omero/insight/tagset">
         <SA:Value>SampleTagset</SA:Value>
      </SA:StringAnnotation>
      <SA:StringAnnotation ID="Annotation:8" Namespace="openmicroscopy.org/omero/annotation/description">
         <SA:Value>This is the description of the sample tagset</SA:Value>
      </SA:StringAnnotation>
      <SA:ListAnnotation ID="Annotation:9" Namespace="openmicroscopy.org/omero/annotation/link">
         <SA:AnnotationRef ID="Annotation:7"/>
         <SA:AnnotationRef ID="Annotation:8"/>
      </SA:ListAnnotation>
      <SA:ListAnnotation ID="Annotation:10" Namespace="openmicroscopy.org/omero/insight/tagset/children">
         <SA:AnnotationRef ID="Annotation:1"/>
         <SA:AnnotationRef ID="Annotation:4"/>
      </SA:ListAnnotation>
   </SA:StructuredAnnotations>

They are not imported as a tab but as a comment. (see attached file)

[jburel]

From what I can see, it is an import problem. .e. String annotation => Textual annotation in DB

[jburel]

The following namespaces openmicroscopy.org/omero/insight/tag and openmicroscopy.org/omero/insight/tagset/children are not defined in Constants.ice
We do not use namespace for tag, the namespace used for a tagset is openmicroscopy.org/omero/insight/tagset

from Constants.ice (the term insight should probably be dropped

module metadata {
        const string NSINSIGHTTAGSET = "openmicroscopy.org/omero/insight/tagset";
        const string NSINSIGHTRATING = "openmicroscopy.org/omero/insight/rating";
        const string NSEDITORPROTOCOL = "openmicroscopy.org/omero/editor/protocol";
        const string NSEDITOREXPERIMENT = "openmicroscopy.org/omero/editor/experiment";
        const string NSMOVIE = "openmicroscopy.org/omero/movie";
        

    };

[jmoore]

Who should be the owner on this?

[ajpatterson]

Ok, it looks like this is just an issue with the 2009 version of the sample files. (When we had tags with a namaspace in a string annotation, before it used a tag annotation.) I am inclined to just remove (or fix) the samples as I don't think this concept was really used.

[Andrew J Patterson <workonly@…>]

(In [d35642b5c4adf9b1dd5dfdd43bdcc7ac29908459/ome.git] on branch develop) Fixing/removing incorrect tag samples, see #9322

[Josh Moore <josh@…>]

(In [2bbe553d26e4449d132ac97db33f0e21e68c0fb4/ome.git] on branch develop) Merge pull request #307 from qidane/develop-9322-fix

Fixing/removing incorrect tag samples, see #9322