Bug: null statsinfo prevent image load

[jamoore]

• ​http://bp.openmicroscopy.org.uk/omero/webclient/?show=image-1953
• "No Channel specified" in web UI
• Exception is being thrown (see OMEROweb.log below) due to a null statsinfo.

[jmoore]

Traceback (most recent call last):
  File "c:\OMERO-CURRENT\lib\python\omero\gateway\__init__.py", line 3324, in __call__
    return self.f(*args, **kwargs)
  File "c:\OMERO-CURRENT\lib\python\omero_api_RenderingEngine_ice.py", line 280, in getPixels
    return _M_omero.api.RenderingEngine._op_getPixels.invoke(self, ((), _ctx))
InternalException: exception ::omero::InternalException
{
    serverStackTrace = ome.conditions.InternalException

	at ome.util.ShallowCopy.reflectiveNewInstance(ShallowCopy.java:35)

	at ome.util.ShallowCopy.copy(ShallowCopy.java:24)

	at ome.services.RenderingBean.copyChannel(RenderingBean.java:1625)

	at ome.services.RenderingBean.copyChannels(RenderingBean.java:1610)

	at ome.services.RenderingBean.copyPixels(RenderingBean.java:1596)

	at ome.services.RenderingBean.getPixels(RenderingBean.java:1087)

	at sun.reflect.GeneratedMethodAccessor1163.invoke(Unknown Source)

	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

	at java.lang.reflect.Method.invoke(Unknown Source)

	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:307)

	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)

	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)

	at ome.services.util.ServiceHandler.invoke(ServiceHandler.java:116)

	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)

	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)

	at $Proxy89.getPixels(Unknown Source)

	at sun.reflect.GeneratedMethodAccessor1163.invoke(Unknown Source)

	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

	at java.lang.reflect.Method.invoke(Unknown Source)

	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:307)

	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)

	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)

	at ome.security.basic.BasicSecurityWiring.invoke(BasicSecurityWiring.java:98)

	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)

	at ome.services.blitz.fire.AopContextInitializer.invoke(AopContextInitializer.java:43)

	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)

	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)

	at $Proxy89.getPixels(Unknown Source)

	at sun.reflect.GeneratedMethodAccessor1222.invoke(Unknown Source)

	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

	at java.lang.reflect.Method.invoke(Unknown Source)

	at ome.services.blitz.util.IceMethodInvoker.invoke(IceMethodInvoker.java:179)

	at ome.services.throttling.Callback.run(Callback.java:56)

	at ome.services.throttling.InThreadThrottlingStrategy.callInvokerOnRawArgs(InThreadThrottlingStrategy.java:56)

	at ome.services.blitz.impl.AbstractAmdServant.callInvokerOnRawArgs(AbstractAmdServant.java:150)

	at ome.services.blitz.impl.RenderingEngineI.getPixels_async(RenderingEngineI.java:200)

	at sun.reflect.GeneratedMethodAccessor1221.invoke(Unknown Source)

	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

	at java.lang.reflect.Method.invoke(Unknown Source)

	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:307)

	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)

	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)

	at omero.cmd.CallContext.invoke(CallContext.java:59)

	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)

	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)

	at $Proxy91.getPixels_async(Unknown Source)

	at omero.api._RenderingEngineTie.getPixels_async(_RenderingEngineTie.java:190)

	at omero.api._RenderingEngineDisp.___getPixels(_RenderingEngineDisp.java:860)

	at omero.api._RenderingEngineDisp.__dispatch(_RenderingEngineDisp.java:1592)

	at IceInternal.Incoming.invoke(Incoming.java:159)

	at Ice.ConnectionI.invokeAll(ConnectionI.java:2037)

	at Ice.ConnectionI.message(ConnectionI.java:972)

	at IceInternal.ThreadPool.run(ThreadPool.java:577)

	at IceInternal.ThreadPool.access$100(ThreadPool.java:12)

	at IceInternal.ThreadPool$EventHandlerThread.run(ThreadPool.java:971)


    serverExceptionClass = ome.conditions.InternalException
    message = 
}
2012-09-24 11:58:06,642 ERROR [             webclient.webclient_gateway] (proc.04664

[jmoore]

Server-side pushed to ​https://github.com/openmicroscopy/openmicroscopy/pull/382

It's still unclear why these are occuring, but the test included in the PR reproduces and fixes this very particular issue. There may be other places in the code base where we assume statsinfo!=null. This needs to be reviewed.

[jmoore <josh@…>]

(In [05be925f19b141138e0259b623260d1f1bcea719/ome.git] on branch develop) Handle InternalException? from null StatsInfo? (Fix #9655)

ShallowCopy?.copy is not intended to handle nulls. Though
it could be changed to do so, that would require a larger
review than I'd like to do at the moment. Handling nulls
inside of RE.getPixels.

[Josh Moore <josh@…>]

(In [b2bacd3e7e96d1cc6ea375265a73e3af7ded6c9d/ome.git] on branch develop) Merge pull request #382 from joshmoore/9655-null-statsinfo

Handle InternalException? from null StatsInfo? (Fix #9655)