Task #10748 (closed)
Bug: Insight responsiveness too slow during import
| Reported by: | mtbcarroll | Owned by: | jburel |
|---|---|---|---|
| Priority: | critical | Milestone: | 5.0.0-beta1 |
| Component: | Insight | Version: | n.a. |
| Keywords: | n.a. | Cc: | ux@…, jrswedlow, jamoore |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | FS demo 4.4 |
Description
While an import is running, Insight can become quite unresponsive: if one selects a dataset in the tree view, the thumbnails stay grey for a while (even over a minute) and clicking one to view the image can similarly take a while to pop up the image viewing window.
This is very intermittent, but has been observed in both dev_4_4 and develop.
Perhaps anybody who witnesses it could capture a stack trace at the time. Or, if anybody has any suspicions as to what may cause it, it would be nice to make sure ahead of time that enough logging is in place to test their hypothesis.
Attachments (4)
Change History (16)
Changed 11 years ago by mtbcarroll
comment:1 Changed 11 years ago by mtbcarroll
It looks like synchronized methods in OMEROGateway are at the root of the issue; witness the blocking in the attached Insight stack trace.
comment:2 Changed 11 years ago by mtbcarroll
(Need to look at both why blockers are so slow, and why they are blocking.)
comment:3 Changed 11 years ago by mtbcarroll
This second set of stack traces shows Insight blocking when also an image view is waiting to pop up.
comment:4 Changed 11 years ago by jburel
Remove the synchronized will unblock the client but there is an underline issue in the thumbail store itself.
The reason why the method call is not released as quickly as it should/was.
Note that the synchronized was added a while ago due to the issues (cannot remember) when we had multiple calls to thumbnail store and having the viewers opened.
So removing will probably lead to other major problems
comment:5 Changed 11 years ago by jburel
The similar problem occurs when a viewer is closed and the image is not rendered yet. The strategy of blocking every call in the RE will have to be reviewed.
comment:6 Changed 11 years ago by jburel
- Milestone changed from Unscheduled to OMERO-5
- Priority changed from major to critical
- Sprint set to FS Demo 4.3
Moving to Fs Demo 3.
Problem is due to the retrieval of thumbnails for large images and the fact that the ThumbnailBean will block
comment:7 Changed 11 years ago by jburel
- Sprint changed from FS Demo 4.3 to FS demo 4.4
Moved from sprint FS Demo 4.3
comment:8 Changed 11 years ago by jburel
Recent changes to import and thumbnail retrieval (see https://github.com/openmicroscopy/openmicroscopy/pull/1252) should improve the experience.
comment:9 Changed 11 years ago by jburel <j.burel@…>
(In [bf47f30fe424068759503ca448f254b67f8aefa0/ome.git] on branch develop) Review loading of thumbnails. (see #10748)
comment:10 Changed 11 years ago by jburel <j.burel@…>
(In [5b86032752279ea1cf6c8c7671071a647fc218b2/ome.git] on branch develop) Do not load thumbnails for image with X*Y>2k*2k (see #10748)
comment:11 Changed 11 years ago by jburel
- Resolution set to fixed
- Status changed from new to closed
Change on develop only, to be back ported over the summer
comment:12 Changed 10 years ago by jburel <j.burel@…>
(In [10ec5ac495db3f73a9ff25a4558f59eb55b8b12a/ome.git]on branches master, dev_4_4) Review loading of thumbnails. (see #10748)
Conflicts:
components/insight/SRC/org/openmicroscopy/shoola/agents/fsimporter/ImportResultLoader.java
blitz stack trace