BUG: Move of MIF does not work when targeted

[pwalczysko]

Gretzky, build OMERO.web 5.0.0-alpha1-1543-6df9497-dirty-ice33-b268.
User-4, group read-only-1, image .svs (MIF consisting of 3 images).
Workflow:

• use "All members" view all the time
• in group read-write create a project and a dataset inside this project
• switch back to read-only-1 group
• select all three images of a MIF
• right-click Move > read-write-1
• a window pops up - choose to move the MIF to the project and dataset prepared in previous step (see screenshot)
• click OK
• Activities entry appears
• After the activity is finished, no link is offered in the Activities line (see screenshot)
• switch to group read-write-1
• the MIF is still in the original group read-only-1 -> no Move took place (although it should have, and the Activities said it did) (see screenshot)

The same MIF is moved as expected if the project / dataset is NOT selected at the Move stage. (it is moved to read-write into Orphaned images as expected)

[wmoore]

Written a test for this Bug. ​https://github.com/openmicroscopy/openmicroscopy/pull/1210
Chgrp with target Dataset works with a single image, but not for 2-image MIF (2 tests, 1 passes, 1 fails).

jrs-macbookpro-25107:test will$ python integration/chgrp.py TestChgrpTarget
.F
======================================================================
FAIL: Chgrp 2 images in a MIF to target Dataset
----------------------------------------------------------------------
Traceback (most recent call last):
  File "integration/chgrp.py", line 550, in testChgrpMifImagesToTargetDataset
    self.chgrpImagesToTargetDataset(2)
  File "integration/chgrp.py", line 531, in chgrpImagesToTargetDataset
    self.doAllSubmit(requests, client, omero_group=target_gid)
  File "/Users/will/Desktop/OMERO/components/tools/OmeroPy/test/integration/library.py", line 649, in doAllSubmit
    rsp = self.doSubmit(da, client, test_should_pass=test_should_pass, omero_group=omero_group)
  File "/Users/will/Desktop/OMERO/components/tools/OmeroPy/test/integration/library.py", line 637, in doSubmit
    self.fail("Found ERR when test_should_pass==true: %s (%s) params=%s" % (rsp.category, rsp.name, rsp.parameters))
AssertionError: Found ERR when test_should_pass==true: ::omero::api::Save (failed) params={'stacktrace': 'ome.conditions.SecurityViolation: Cannot read ome.model.core.Image:Id_67\n\tat ome.security.basic.BasicACLVoter.throwLoadViolation(BasicACLVoter.java:163)
	at ome.security.CompositeACLVoter.throwLoadViolation(CompositeACLVoter.java:92)
	at ome.security.ACLEventListener.onPostLoad(ACLEventListener.java:104)
	at org.hibernate.engine.TwoPhaseLoad.initializeEntity(TwoPhaseLoad.java:250)
	at org.hibernate.loader.Loader.initializeEntitiesAndCollections(Loader.java:898)
...
	 'message': 'Cannot read ome.model.core.Image:Id_67', 'obj': 'omero.model.DatasetImageLinkI@2f1f76a1'}

----------------------------------------------------------------------
Ran 2 tests in 14.265s

FAILED (failures=1)

[jamoore]

Comment added to PR 1210. I think the issue stems from not performing all omero.cmd.Save operations at the end of the DoAll. Passing back to Will for review.

[wmoore]

Fix is in the same PR as the tests ​https://github.com/openmicroscopy/openmicroscopy/pull/1210

[Will Moore <will@…>]

(In [2ffe24f1d04a6ced619f53242cf7f1be4ea67797/ome.git] on branch develop) Add 'omero.group' to lib.doSubmit() for chgrp target. See #10908

[Will Moore <will@…>]

(In [0411b5df8e01f932c12d0a474d1b20536655795e/ome.git] on branch develop) Chgrp to target Dataset. Fails for 2-image MIF. See #10908