Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Bug #1499 (new)

Opened 15 years ago

Last modified 15 years ago

Import regressions due to refactoring for CLI — at Version 31

Reported by: jamoore Owned by: bwzloranger
Priority: critical Cc: jrswedlow, jburel
Sprint: n.a.
Total Remaining Time: n.a.

Description (last modified by jmoore)

To have much of the newer ImportLibrary functionality in both the cli and the gui versions, refactoring was necessary which introduced several bugs:

  • #1486 returning null from ImportCandidates.singleFile
  • NPE from #1503 (see below)
  • mouseover since multiple files can be added in one click? (see below)
  • feedback no longer uploads files (fixed)
  • warning printed: "Couldn't find icon: gfx/warning_msg16.png" (fixed)
  • re-login panel has issues (fixed)
  • properties on error dialog not saved (fixed)
  • mac app and windows exe fail
  • history not showing up (fixed)
  • history not 'reimporting'(fixed)
  • files which fail during importcandidate not showing up on queue (fixed)
  • error in filequeue not being added to feedback queue (fixed)
  • eclipse builds failing without testng being built (fixed)
  • feedback no longer recording some properties (such as 'additional_files_path' and 'additional_files_size') (fixed)
  • 'internal errors' not providing required information for feedback such as reader file types (fixed)
  • Properties on filechooser not being saved (partially fixed still not registering in some cases)
  • Properties on error feedback not being saved (fixed)
  • Properties on project/dataset/spw not being saved (fixed)
  • files do not preserve the name specified for them in the import dialog
  • It is no longer possible to log into the server more then once from the same machine.
  • Importer version should be taken from omero.properties
  • On failed files, popup no longer showing up at the end of the import process. (fixed)
  • Some error messages (Internal Errors) no longer appear to be providing the full stack trace to the feedback mechanism (fixed)
  • ImportCandidate? interfering with the reader used during imports so clicking on the 'add button' will poison the import reader if its running, causing imports to fail - ImportCandidate? will probably need to be moved to its own reader. (Fixed by disabling the add button for now)
  • Added importHandler events for IMPORT_QUEUE_DONE - some code from this class can now be moved back into the classes where they belong. (fixed)
  • Added importHandler event for IMPORT_QUEUE_START (fixed)
  • When ping session dies, app does not properly register as 'logged out'
  • Icon for debug message popup wrong (fixed)
  • Failure dialog and project/dataset dialog both modal and blocking each other. (fixed)

Change History (31)

comment:1 Changed 15 years ago by jmoore

  • Description modified (diff)

comment:2 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:3 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:4 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:5 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:6 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:7 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:8 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:9 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:10 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:11 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:12 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:13 Changed 15 years ago by jmoore

  • Description modified (diff)

comment:14 Changed 15 years ago by jmoore

  • Description modified (diff)

comment:15 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:16 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:17 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:18 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:19 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:20 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:21 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:22 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:23 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:24 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:25 Changed 15 years ago by jmoore

  • Description modified (diff)

Further explanation on "mouseover since multiple files":

If a user clicks a directory, say "My Plates" for import, then a single file will show up for each plate. Something of the form: mode0001_z001_t0001.tif. The user will have no way to know which one relates to which plate.

comment:26 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:27 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:28 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:29 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:30 Changed 15 years ago by bwzloranger

  • Description modified (diff)

comment:31 Changed 15 years ago by jmoore

  • Description modified (diff)

From #1503 error.log:

11	Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
12	        at javax.swing.text.DefaultStyledDocument.getCharacterElement(Unknown Source)
13	        at javax.swing.text.StyledEditorKit$AttributeTracker.updateInputAttributes(Unknown Source)
14	        at javax.swing.text.StyledEditorKit$AttributeTracker.caretUpdate(Unknown Source)
15	        at javax.swing.text.JTextComponent.fireCaretUpdate(Unknown Source)
16	        at javax.swing.text.JTextComponent$MutableCaretEvent.fire(Unknown Source)
17	        at javax.swing.text.JTextComponent$MutableCaretEvent.stateChanged(Unknown Source)
18	        at javax.swing.text.DefaultCaret.fireStateChanged(Unknown Source)
19	        at javax.swing.text.DefaultCaret.changeCaretPosition(Unknown Source)
20	        at javax.swing.text.DefaultCaret.handleSetDot(Unknown Source)
21	        at javax.swing.text.DefaultCaret.setDot(Unknown Source)
22	        at javax.swing.text.DefaultCaret.setDot(Unknown Source)
23	        at javax.swing.text.JTextComponent.setCaretPosition(Unknown Source)
24	        at ome.formats.importer.gui.GuiImporter$5.adjustmentValueChanged(GuiImporter.java:317) 
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.83166 sec.)

We're Hiring!