Task #9500 (closed)
Bug: Inject host/port into PublicRepositoryI
| Reported by: | cblackburn | Owned by: | jamoore |
|---|---|---|---|
| Priority: | critical | Milestone: | OMERO-4.4.7 |
| Component: | OmeroFs | Version: | n.a. |
| Keywords: | n.a. | Cc: | cxallan, jamoore |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2012-10-23 (1) |
Description
The host and port are hard-coded in the importMetadata method. There's even a nice TODO for it to be fixed but not ticket was raised at the time. Now it needs doing!
Change History (6)
comment:1 Changed 12 years ago by cblackburn
- Milestone changed from OMERO-4.4.2 to Future
- Owner set to cblackburn
- Sprint 2012-08-28 (3) deleted
comment:2 Changed 12 years ago by jmoore
- Milestone changed from Future to OMERO-4.4.x
Moving to 4.4.x (soon to be 4.5.0) with the rest of the fs-lite stuff.
comment:3 Changed 12 years ago by jmoore
Referencing ticket #909 has changed sprint.
comment:4 Changed 12 years ago by jmoore
- Owner changed from cblackburn to jmoore
- Remaining Time set to 0.1
- Sprint set to 2012-10-23 (1)
- Status changed from new to accepted
Fixed via Blitz Registry on my fslite branch.
comment:5 Changed 12 years ago by jmoore
- Remaining Time changed from 0.1 to 0
- Resolution set to fixed
- Status changed from accepted to closed
commit 19b4bbf3e25622301676f4a258d860e432972c3a
Author: jmoore <josh@glencoesoftware.com>
Date: Sun Sep 30 15:29:19 2012
Refactor hard-coded import connection (Fix #9500)
Rather than passing a server and port we connect now
to the server manager internally and retrieve the
existing ServiceFactoryPrx. A future version may want
to create a separate session for the import process so
that if the client exists the process can still complete.
Haven't opened a PR yet since 383 hasn't been merged. Will do so asap.
comment:6 Changed 12 years ago by jmoore <josh@…>
(In [7ae0ea675ad8cc4a6489f7c92587d1dc987e7044/ome.git] on branch develop) Refactor hard-coded import connection (Fix #9500)
Rather than passing a server and port we connect now
to the server manager internally and retrieve the
existing ServiceFactoryPrx?. A future version may want
to create a separate session for the import process so
that if the client exists the process can still complete.
This bug is only in the fs-lite import code and so not relevant to 4.4.2. I've moved the ticket to future for now.