Task #9565 (closed)
Bug: XML Sample file not valid
Reported by: | jburel | Owned by: | ajpatterson |
---|---|---|---|
Priority: | major | Milestone: | OMERO-4.4.4 |
Component: | Specification | Version: | n.a. |
Keywords: | n.a. | Cc: | cxallan |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | 2012-09-11 (4) |
Description
while testing ROI I had a closer look at the XML file with ROI
i.e. 6x4y1z1t1c8b-swatch-downgrade.ome
The sample file is not correct i.e.
<OME:Pixels DimensionOrder="XYCZT" ID="Pixels:0:0" PhysicalSizeX="10000.0" PhysicalSizeY="10000.0" Type="uint8" SizeC="3" SizeT="1" SizeX="6" SizeY="4" SizeZ="1">
Since the size of T and Z is 1, the theZ and theT should be 0 not 1.
<ROI:Shape ID="Shape:4" FillRule="EvenOdd" FontStyle="Normal" FontFamily="serif" Text="Hello" FillColor="1" FontSize="1" LineCap="Butt" StrokeColor="1" StrokeDashArray="10 10" StrokeWidth="1" TheC="1" TheT="1" TheZ="1" Visible="true">
Other similar samples files need to be reviewed.
Change History (6)
comment:1 Changed 12 years ago by ajpatterson
comment:2 Changed 12 years ago by ajpatterson
http://github.com/openmicroscopy/openmicroscopy/pull/345 for develop
and
http://github.com/openmicroscopy/openmicroscopy/pull/346 for schema-2012-06 (but just as a placeholder - it needs cherry picked)
comment:3 Changed 12 years ago by ajpatterson
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed 12 years ago by ajpatterson
Got cherry pick to work, commit for schema-2012-06 now on PR
http://github.com/openmicroscopy/openmicroscopy/pull/272
comment:5 Changed 12 years ago by Andrew J Patterson <workonly@…>
(In [4e3053c755a4a54fe74ea2863bb8d87fe2597a26/ome.git] on branch develop) Fix off-by-one error in T/Z/C of ROIs, see #9565
Also added a couple more lines to readme file.
comment:6 Changed 12 years ago by Josh Moore <josh@…>
(In [b319a8ceea463f1a213743a2537a2a537a1aeef8/ome.git] on branch develop) Merge pull request #345 from qidane/develop-9565-fix
Fix off-by-one error in T/Z/C of ROIs, see #9565
Only this file:
and it's output after the downgrade
are affected.